Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idea: separate js embeds and html embeds #129

Open
jaccomeijer opened this issue Sep 6, 2020 · 0 comments
Open

Idea: separate js embeds and html embeds #129

jaccomeijer opened this issue Sep 6, 2020 · 0 comments
Labels
enhancement New feature or request improve wheel question Further information is requested

Comments

@jaccomeijer
Copy link
Contributor

jaccomeijer commented Sep 6, 2020

Embeds are good voor embedding javascript for handling events.

Content editors should not have to bother with html code however.

Idea:

  • Remove html type from embed
  • Remove embeds from topic model
  • Add two new simple text fields to topic model:
    • mediaType: fixed dropdown with 'you tube', 'vimeo', etc.
    • mediaCode: the code that can be used to initialise the embedded player
@jaccomeijer jaccomeijer added enhancement New feature or request question Further information is requested improve wheel labels Sep 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request improve wheel question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant