Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite plugin system #132

Open
jaccomeijer opened this issue Sep 6, 2020 · 0 comments
Open

Rewrite plugin system #132

jaccomeijer opened this issue Sep 6, 2020 · 0 comments

Comments

@jaccomeijer
Copy link
Contributor

jaccomeijer commented Sep 6, 2020

With the current plugin system plugins register themselves independent of other plugins.

The main disadvantage of this approach is that each plugin registration causes a DOM render.

We have to register plugins differently. Plugins can be imported and they the register call can pass all the plugins as an array.

Bug #117 can then be solved easily by checking the pre-renderend theme. If the pre-rendered theme is different from the theme that should be rendered based on OS UI color settings, render the correct theme instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant