You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I was having several weird eslint issue around this package, and I think I've tracked them down to this. This isn't a valid package.json file according to npm docs.
The popular eslint plugin eslint-plugin-import attempts to find package names from resolved file paths:
This means in certain cases eslint will find this bad package.json and not be able to find a package name for the corresponding file.
It seems like ideally there would be no package.json included in the dist directory, but if one is necessary it should probably be complete and valid. If a direction can be decided upon here I can probably work on a PR.
The text was updated successfully, but these errors were encountered:
This package seems to ship with a partial package.json in the dist directory because of this line:
fetch-mock/Makefile
Line 50 in 4b54e6d
I was having several weird eslint issue around this package, and I think I've tracked them down to this. This isn't a valid package.json file according to npm docs.
The popular eslint plugin
eslint-plugin-import
attempts to find package names from resolved file paths:https://github.com/benmosher/eslint-plugin-import/blob/7aea664b8f6859aa9e8a0d808ab71cf96576f299/src/core/packagePath.js#L15-L18
This means in certain cases eslint will find this bad package.json and not be able to find a package name for the corresponding file.
It seems like ideally there would be no package.json included in the dist directory, but if one is necessary it should probably be complete and valid. If a direction can be decided upon here I can probably work on a PR.
The text was updated successfully, but these errors were encountered: