Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node-fetch dependency to v3.x.x #620

Open
akhmadullin opened this issue Sep 15, 2021 · 4 comments
Open

Update node-fetch dependency to v3.x.x #620

akhmadullin opened this issue Sep 15, 2021 · 4 comments

Comments

@akhmadullin
Copy link

Hi.

node-fetch released new major version - 3.0.0

https://github.com/node-fetch/node-fetch/releases/tag/v3.0.0

Are you planning to update node-fetch dependency to ^3.x.x in fetch-mock?

@wheresrhys
Copy link
Owner

node-fetch@3 is ES modules only, so it would require updating this entire library from commonjs. Probably something I'll look at after addressing the ling backlog of other issues

@rainerbruemmer
Copy link

Hi @wheresrhys,

are there any news regarding node-fetch@3 compatibility?

@guillaumewuip
Copy link

Because of the * peerDependencies version field, users of fetch-mock can't see something is wrong when installing node-fetch@3.x.x:

fetch-mock/package.json

Lines 48 to 50 in 1bdac54

"peerDependencies": {
"node-fetch": "*"
},

Are you open to a PR updating the node-fetch peerDependencies version field to be < 3.0.0 for example? This could be released as a patch IMO.

   "peerDependencies": {
-    "node-fetch": "*"
+    "node-fetch": "< 3.0.0"
   },

@rudolfbyker
Copy link

Related: #625

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants