Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Mojave Dark Mode Support #34

Closed
cal2195 opened this issue Dec 21, 2018 · 4 comments 路 Fixed by #211
Closed

Add Mojave Dark Mode Support #34

cal2195 opened this issue Dec 21, 2018 · 4 comments 路 Fixed by #211
Assignees
@whyboris
Labels
2.0.0 Priority for v2.0.0 release enhancement Improves existing features good first issue Good for newcomers
Projects
Boris's Current Workflow
Milestone
v2.0.0

Comments

@cal2195
Copy link
Collaborator

cal2195 commented Dec 21, 2018

Electron v4.0.0 now has APIs to support Mojave's Dark Mode! 馃帀

electron/electron#13387

We should support this! 馃挴
@cal2195 cal2195 added the enhancement Improves existing features label Dec 21, 2018
@cal2195 cal2195 added this to the v2.0.0 milestone Dec 21, 2018
@whyboris
Copy link
Owner

Should be pretty straight-forward! We have a dark mode in the app already -- it's just a matter of hooking up the setting to trigger the change, right? 馃榿

@cal2195
Copy link
Collaborator Author

cal2195 commented Dec 21, 2018

Exactly! 馃挴

@whyboris whyboris added the good first issue Good for newcomers label Jan 5, 2019
@whyboris whyboris modified the milestones: v2.0.0, Likely Jan 5, 2019
@whyboris
Copy link
Owner

Cool -- now I have Mojave on my Mac -- I'll be able to add the code and test it out 馃憣

@whyboris whyboris added the 2.0.0 Priority for v2.0.0 release label Jul 13, 2019
@whyboris whyboris self-assigned this Jul 13, 2019
@whyboris whyboris added this to In progress in Boris's Current Workflow Jul 13, 2019
@whyboris whyboris moved this from In progress to In review in Boris's Current Workflow Jul 13, 2019
@whyboris whyboris mentioned this issue Jul 13, 2019
Merged
@whyboris whyboris modified the milestones: Likely, v2.0.0 Jul 14, 2019
@whyboris
Copy link
Owner

Will be in 2.0.0 - PR #211 -- waiting for Electron 5.0.7 to be released as it provides a needed bugfix 馃憤

@whyboris whyboris moved this from In review to Stalled in Boris's Current Workflow Jul 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@whyboris whyboris

Labels
2.0.0 Priority for v2.0.0 release enhancement Improves existing features good first issue Good for newcomers
Projects
Boris's Current Workflow
  
Stalled
Milestone
v2.0.0
Development

Successfully merging a pull request may close this issue.

OS X - dark mode whyboris/Video-Hub-App
2 participants
@cal2195 @whyboris