initial add of mlir and tblgen lsp #2379
Conversation
There was a problem hiding this comment.
Hey! Thanks for the PR! The package definition is incomplete because it's not providing information about what to actually download, the only information is a GitHub repository.
This will be problematic to add as standalone packages because they are bundled with the entire clang+llvm bundle (which provides countless of binaries and is almost 1G large). For this reason I don't see it being feasible to add them to the registry, and users will have to install it elsewhere, for example installing llvm via the system manager.
|
Given it's in neovim-lspconfig, I don't believe these LSPs require a full LLVM install, since these LSPs are extensions. https://github.com/neovim/nvim-lspconfig/blob/master/doc/server_configurations.md#mlir_lsp_server So I thought it would be okay to add to this registry. Though I am ignorant of doing that properly. Please correct me if I am wrong. I'll try to understand better and if the extensions don't require the full LLVM, I'll hopefully submit a more sufficient PR. |
|
I believe the VSCode extension relies on these binaries to be installed externally in order to function. Neovim's equivalent to a dedicated VSCode language plugin would be a server configuration entry in |
Hi there,
All three are from the LLVM project and are in the nvim-lspconfig repo so this should be straightforward. However, this is my first time contributing so I may need some guidance. In particular, please review the
sourceandbin.https://github.com/neovim/nvim-lspconfig/blob/master/doc/server_configurations.md#mlir_lsp_server
https://github.com/neovim/nvim-lspconfig/blob/master/doc/server_configurations.md#mlir_pdll_lsp_server
https://github.com/neovim/nvim-lspconfig/blob/master/doc/server_configurations.md#tblgen_lsp_server
Attempting to resolve williamboman/mason-lspconfig.nvim#234