Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Typescript stuff and add API types #14

Open
willianjusten opened this issue Feb 4, 2022 · 2 comments
Open

Fix Typescript stuff and add API types #14

willianjusten opened this issue Feb 4, 2022 · 2 comments
Labels
enhancement New feature or request Logic

Comments

@willianjusten
Copy link
Owner

No description provided.

@willianjusten willianjusten added Logic enhancement New feature or request labels Feb 4, 2022
@willianjusten willianjusten added this to the MVP 1 - Show info milestone Feb 5, 2022
@willianjusten willianjusten removed this from the MVP 1 - Show info milestone Feb 23, 2022
@lucianomlima
Copy link

Can put some info about the TS errors and types to be improved?

@willianjusten
Copy link
Owner Author

There are no errors actually, but places that we could improve and organize, if you see our types file:
https://github.com/willianjusten/nba-remix/blob/main/app/types.ts

There are many repeated things that we could separate and organize. This ticket is mostly to check our type places and improve it. When I started the project, I did the fastest way as possible, so there are always places to improve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Logic
Projects
None yet
Development

No branches or pull requests

2 participants