Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Player/Team Stats tabs in Game page #90

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

grippado
Copy link
Contributor

@grippado grippado commented Mar 12, 2022

Initial proposal to resolve #46,
put team and player stats in tabs functionality, and extend this functionality to standings page.

I'm using react-tabs for this issue/feature

image1
image2

Need some help in styling and TS Typo waning.

[[ WIP ]]

Roadmap:

  • Add tabs to players/teams game page (image1)
  • Add tabs to standings page (image2)
  • Tables width inside panels
  • General styling
  • Mobile Players table width not fit screen
  • Tab selected and tabs line styling
  • Storybook entry
  • Test entry
  • Warning on use vTeam with TeamPlayerStats type
  • react-tabs: Warning in Prop id did not match. Server: react-tabs-90 Client: react-tabs-0
  • Remove comments and unused code
  • Fixing fail tests from modified components

@vercel
Copy link

vercel bot commented Mar 12, 2022

Someone is attempting to deploy a commit to a Personal Account owned by @willianjusten on Vercel.

@willianjusten first needs to authorize it.

@vercel
Copy link

vercel bot commented Mar 12, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/willianjusten/nba-remix/3TrJcWBCpjMkuLge51Hboh4Ayben
✅ Preview: https://nba-remix-git-fork-grippado-feat-tabs-play-c0c061-willianjusten.vercel.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create accordion to PlayerStats / TeamStats
1 participant