Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hello from microlink #16

Open
Kikobeats opened this issue Aug 10, 2019 · 0 comments
Open

Hello from microlink #16

Kikobeats opened this issue Aug 10, 2019 · 0 comments

Comments

@Kikobeats
Copy link

Kikobeats commented Aug 10, 2019

Hello, sir

We noted you did a copy of our library, Microlink SDK.

Nothing bad there, but after analyzing the code, I noted that the only difference here is, while Microlink SDK uses Microlink API for getting the data, you are using a set of rules over popular sites.

Well, actually you can do that using setData:

import Microlink from '@microlink/react'

export default () => (
  <Microlink
    url='https://www.instagram.com/p/Bt6EMQhHHIr/'
    setData={data => ({ 
     /* your data interface here! */
    }})
  />

Doing that, you don't need to rewrite all the library; just create a Higher Order Component over Microlink SDK.

Also, I'm very open to collaborate and join efforts 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant