Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: winstonjs/winston
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.3.2
Choose a base ref
...
head repository: winstonjs/winston
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3.3.3
Choose a head ref
  • 4 commits
  • 4 files changed
  • 3 contributors

Commits on Jun 23, 2020

  1. Fix issue #1817 (#1819)

    * fix: replace type with generic
    
    * fix: typo
    Pigotz authored Jun 23, 2020

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    bc6f681 View commit details
  2. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    35b0774 View commit details
  3. Prepare for 3.3.3

    DABH committed Jun 23, 2020
    Copy the full SHA
    c416e3a View commit details
  4. 3.3.3

    DABH committed Jun 23, 2020
    Copy the full SHA
    7b46dc8 View commit details
Showing with 32 additions and 30 deletions.
  1. +4 −0 CHANGELOG.md
  2. +26 −28 index.d.ts
  3. +1 −1 package-lock.json
  4. +1 −1 package.json
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# CHANGELOG

## v3.3.3 / 2020-06-23

- [#1820] Revert [#1807] to resolve breaking changes for Typescript users.

## v3.3.2 / 2020-06-22

- [#1814] Use a fork of `diagnostics` published to NPM to avoid git dependency.
54 changes: 26 additions & 28 deletions index.d.ts
Original file line number Diff line number Diff line change
@@ -58,7 +58,7 @@ declare namespace winston {
[optionName: string]: any;
}

interface LogMethod {
interface LogMethod {
(level: string, message: string, callback: LogCallback): Logger;
(level: string, message: string, meta: any, callback: LogCallback): Logger;
(level: string, message: string, ...meta: any[]): Logger;
@@ -74,8 +74,8 @@ declare namespace winston {
(infoObject: object): Logger;
}

interface LoggerOptions<T extends Config.AbstractConfigSetLevels = Config.AbstractConfigSetLevels> {
levels?: T;
interface LoggerOptions {
levels?: Config.AbstractConfigSetLevels;
silent?: boolean;
format?: logform.Format;
level?: string;
@@ -86,29 +86,7 @@ declare namespace winston {
exceptionHandlers?: any;
}

type DefaulLevels = {
// for cli and npm levels
error: number;
warn: number;
help: number;
data: number;
info: number;
debug: number;
prompt: number;
http: number;
verbose: number;
input: number;
silly: number;

// for syslog levels only
emerg: number;
alert: number;
crit: number;
warning: number;
notice: number;
}

type Logger<T extends Config.AbstractConfigSetLevels = DefaulLevels> = NodeJSStream.Transform & {
interface Logger extends NodeJSStream.Transform {
silent: boolean;
format: logform.Format;
levels: Config.AbstractConfigSetLevels;
@@ -125,6 +103,26 @@ declare namespace winston {
clear(): Logger;
close(): Logger;

// for cli and npm levels
error: LeveledLogMethod;
warn: LeveledLogMethod;
help: LeveledLogMethod;
data: LeveledLogMethod;
info: LeveledLogMethod;
debug: LeveledLogMethod;
prompt: LeveledLogMethod;
http: LeveledLogMethod;
verbose: LeveledLogMethod;
input: LeveledLogMethod;
silly: LeveledLogMethod;

// for syslog levels only
emerg: LeveledLogMethod;
alert: LeveledLogMethod;
crit: LeveledLogMethod;
warning: LeveledLogMethod;
notice: LeveledLogMethod;

query(options?: QueryOptions, callback?: (err: Error, results: any) => void): any;
stream(options?: any): NodeJS.ReadableStream;

@@ -144,7 +142,7 @@ declare namespace winston {
isSillyEnabled(): boolean;

new(options?: LoggerOptions): Logger;
} & {[K in keyof T]: LeveledLogMethod;}
}

interface Container {
loggers: Map<string, Logger>;
@@ -164,7 +162,7 @@ declare namespace winston {
let loggers: Container;

let addColors: (target: Config.AbstractConfigSetColors) => any;
let createLogger: <T extends Config.AbstractConfigSetLevels = DefaulLevels>(options?: LoggerOptions<T>) => Logger<T>;
let createLogger: (options?: LoggerOptions) => Logger;

// Pass-through npm level methods routed to the default logger.
let error: LeveledLogMethod;
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "winston",
"description": "A logger for just about everything.",
"version": "3.3.2",
"version": "3.3.3",
"author": "Charlie Robbins <charlie.robbins@gmail.com>",
"maintainers": [
"Jarrett Cruger <jcrugzz@gmail.com>",