Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): Allow any object to be passed as meta to logger.profile #2314

Merged
merged 1 commit into from
Jun 28, 2023
Merged

fix(types): Allow any object to be passed as meta to logger.profile #2314

merged 1 commit into from
Jun 28, 2023

Conversation

sokki
Copy link
Contributor

@sokki sokki commented Jun 20, 2023

It was typed as LogEntry which requires both level and message to be set. That contradicts the implementation that treats these fields as optional.

fixes #1969

@DABH
Copy link
Contributor

DABH commented Jun 25, 2023

@sokki , if you merge master into your branch or rebase your PR on master, I think the tests should pass thanks to #2315 . Give it a try and let's see (feel free to @ me so I see the result).

DABH
DABH approved these changes Jun 25, 2023
View reviewed changes
Copy link
Contributor

@DABH DABH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve once CI passes

@sokki
fix(types): Allow any object to be passed as meta to logger.profile
5c3f3ba 
It was typed as `LogEntry` which requires both `level` and `message` to be set. That contradicts the implementation that treats these fields as optional.

fixes winstonjs#1969
@sokki
Copy link
Contributor Author

sokki commented Jun 26, 2023

@DABH I rebased onto master. CI needs manual approval to run.

@DABH DABH merged commit 9d6001a into winstonjs:master Jun 28, 2023
4 checks passed
This was referenced May 19, 2024
Open
Open
@paaschdigital paaschdigital mentioned this pull request May 20, 2024
Open
This was referenced May 21, 2024
Open
Open
Open
@cvs-ops cvs-ops mentioned this pull request May 24, 2024
Open
@rish2497 rish2497 mentioned this pull request May 24, 2024
Open
This was referenced May 24, 2024
Open
Open
@rish2497 rish2497 mentioned this pull request May 25, 2024
Open
@nc-minh nc-minh mentioned this pull request May 25, 2024
Open
@cvs-ops cvs-ops mentioned this pull request May 25, 2024
Open
@slatersnyk slatersnyk mentioned this pull request May 25, 2024
Open
@fanibahar fanibahar mentioned this pull request May 25, 2024
Open
@paladinmansouri paladinmansouri mentioned this pull request May 26, 2024
Open
@marcos-test-dev marcos-test-dev mentioned this pull request May 26, 2024
Open
@drwho725 drwho725 mentioned this pull request May 26, 2024
Closed
This was referenced May 26, 2024
Open
Open
@AnushaSalian AnushaSalian mentioned this pull request May 30, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Jun 1, 2024
Open
@TheTechSurgeon TheTechSurgeon mentioned this pull request Jun 1, 2024
Open
@ksalman-Cx ksalman-Cx mentioned this pull request Jun 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DABH DABH DABH approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Doc bug for profile(), or missing implementation
2 participants
@sokki @DABH