Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move EncryptionStream to SubtleCrypto? #6

Open
twiss opened this issue Feb 8, 2023 · 0 comments
Open

Move EncryptionStream to SubtleCrypto? #6

twiss opened this issue Feb 8, 2023 · 0 comments

Comments

@twiss
Copy link

twiss commented Feb 8, 2023

Hey 馃憢 Thanks for working on this, and apologies for not looking at the spec earlier!

As a high-level comment, I would argue EncryptionStream should live in the same namespace as crypto.subtle.encrypt. After all, it's equally "subtle" as that function, and people should be careful not to use unauthenticated algorithms by themselves, for example. So I think having some indication of that in the name (e.g. crypto.subtle.EncryptionStream) would be good.

Also, without necessarily advocating for doing so, if we ever want to add DecryptionStream, that would be even more "subtle" (since you have to be careful not to accidentally use unauthenticated data), so that should definitely have to live under SubtleCrypto, IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant