Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace com.google.common.base.Optional with Java 11 implementation #2120

Merged
merged 17 commits into from
May 31, 2023

Conversation

pks-1981
Copy link
Contributor

@pks-1981 pks-1981 commented Mar 30, 2023

Replace com.google.common.base.Optional

For #2111

@pks-1981
Copy link
Contributor Author

pks-1981 commented Apr 2, 2023

@timtebeek @tomakehurst waiting for review)

Kirill Peshin added 5 commits April 23, 2023 10:48
# Conflicts:
#	src/main/java/com/github/tomakehurst/wiremock/matching/StringValuePatternJsonDeserializer.java
# Conflicts:
#	src/main/java/com/github/tomakehurst/wiremock/servlet/WireMockHttpServletRequestAdapter.java
#	src/main/java/com/github/tomakehurst/wiremock/verification/LoggedRequest.java
@oleg-nenashev oleg-nenashev added the breaking Breaking change label May 5, 2023
@oleg-nenashev oleg-nenashev changed the title Replace com.google.common.base.Optional Replace com.google.common.base.Optional with Java 11 implementation May 5, 2023
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from me. It is breaking binary compatibility, which is something we plan for WireMock 3.0 in the case of Guava&Co

@oleg-nenashev oleg-nenashev added the needs-tom Tom's Train Project :) label May 6, 2023
@tomakehurst tomakehurst merged commit 884bcbd into wiremock:master May 31, 2023
7 checks passed
@pks-1981 pks-1981 deleted the optional branch June 1, 2023 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change chore Maintenance needs-tom Tom's Train Project :)
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants