Fix JUnit5 extension bug when using both declarative + programmatic simultaneously #2123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
declarative and programmatic approach simultaneously
oleg-nenashev
approved these changes
Apr 11, 2023
|
Please can we fix the formatting issues so that the tests can run? |
|
Thanks, and sorry for the wait! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2122, please see the issue described there for details.
This PR makes it so that the options of httpPort/httpsPort/httpsEnabled/proxyMode and anything else that might be configured through the
@WireMockTestattribute for a declarative setup in JUnit5 does not override programmatically configured options.