Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate dependencies #2177

Merged

Conversation

picimako
Copy link
Contributor

There were two libraries whose dependency entries in build.gradle were duplicated. Both duplicates are removed.

References

None.

Submitter checklist

  • The PR request is well described and justified, including the body and the references
  • The PR title represents the desired changelog entry
  • The repository's code style is followed (see the contributing guide)
  • Test coverage that demonstrates that the change works as expected
  • For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

@oleg-nenashev oleg-nenashev added the chore Maintenance label May 15, 2023
@oleg-nenashev
Copy link
Member

Test failure is unrelated

WireMockJUnitRuleTest > com.github.tomakehurst.wiremock.WireMockJUnitRuleTest$PortNumbers > reportedPortIsAsConfiguredInRule FAILED
    com.github.tomakehurst.wiremock.common.FatalStartupException: java.lang.RuntimeException: java.io.IOException: Failed to bind to /0.0.0.0:33175
        at app//com.github.tomakehurst.wiremock.WireMockServer.start(WireMockServer.java:160)
        at app//com.github.tomakehurst.wiremock.junit.WireMockRule$1.evaluate(WireMockRule.java:57)
        at app//org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
        at app//org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
        at app//org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
        at app//org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
        at app//org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
        at app//org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
        at app//org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
        at app//org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
        at app//org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
        at app//org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
        at app//com.github.tomakehurst.wiremock.junit.WireMockClassRule$1.evaluate(WireMockClassRule.java:75)
        at app//org.junit.rules.RunRules.evaluate(RunRules.java:20)

@oleg-nenashev oleg-nenashev merged commit 7da67fc into wiremock:master Jul 4, 2023
7 checks passed
@oleg-nenashev oleg-nenashev added dependencies Pull requests that update a dependency file chore Maintenance and removed chore Maintenance dependencies Pull requests that update a dependency file labels Jul 5, 2023
@picimako picimako deleted the remove-duplicate-dependencies branch November 7, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants