Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2197 | added field "mappings" to StubMapping and its processing if it exists #2198

Conversation

DjerohN
Copy link
Contributor

@DjerohN DjerohN commented May 30, 2023

This pull request adds field "mappings" to StubMapping class and processing to load() method of RemoteMappingsLoader class if present

References

Submitter checklist

  • The PR request is well described and justified, including the body and the references
  • The PR title represents the desired changelog entry
  • The repository's code style is followed (see the contributing guide)
  • Test coverage that demonstrates that the change works as expected
  • For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

@DjerohN
Copy link
Contributor Author

DjerohN commented May 30, 2023

@tomakehurst
Copy link
Member

This isn't the right approach - there's already StubMappingCollection for this purpose which is used when reading the mappings directory via JsonFileMappingsSource. I suggest we adapt RemoteMappingsLoader to work the same way.

@DjerohN
Copy link
Contributor Author

DjerohN commented May 30, 2023

Used StubMappingCollection as @tomakehurst suggested

@tomakehurst
Copy link
Member

Please could you run ./gradlew spotlessApply and push the fixes?

@DjerohN
Copy link
Contributor Author

DjerohN commented May 31, 2023

Done

@tomakehurst tomakehurst merged commit 47f3a49 into wiremock:master May 31, 2023
7 checks passed
@tomakehurst
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support multiple mappings files when remotely loading stubs from the filesystem
2 participants