Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependencies on new:ing collections with Guava (refs #2111) #2254

Merged

Conversation

tomasbjerre
Copy link
Contributor

A small step removing some imports from Guava.

References

#2111

Submitter checklist

  • The PR request is well described and justified, including the body and the references
  • The PR title represents the desired changelog entry
  • The repository's code style is followed (see the contributing guide)
  • Test coverage that demonstrates that the change works as expected
  • For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

@tomasbjerre tomasbjerre requested a review from a team as a code owner July 10, 2023 14:16
@tomasbjerre
Copy link
Contributor Author

tomasbjerre commented Jul 10, 2023

I think the failing Build and test / build (macos-latest, 17) (pull_request) here might be a because of a timing issue, a toggling test case maby?

ResponseTemplateTransformerTest > canHandleALargeTemplateReasonablyFast() FAILED
    java.lang.AssertionError: 
    Expected: a value less than <PT5S>
         but: <PT5.440965S> was greater than <PT5S>
        at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
        at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:6)
        at com.github.tomakehurst.wiremock.extension.responsetemplating.ResponseTemplateTransformerTest.canHandleALargeTemplateReasonablyFast(ResponseTemplateTransformerTest.java:1026)

@Mahoney
Copy link
Collaborator

Mahoney commented Jul 10, 2023

Yes, that's almost certainly just a performance issue... we should probably bump the expectation up to 10 seconds or something to prevent it happening again. The problem it's checking for was making them take minutes, so that should be OK.

@oleg-nenashev oleg-nenashev added the chore Maintenance label Jul 11, 2023
@oleg-nenashev oleg-nenashev changed the title chore: removing dependencies on new:ing collections with Guava (refs #2111) Remove dependencies on new:ing collections with Guava (refs #2111) Jul 11, 2023
@oleg-nenashev
Copy link
Member

Created #2259 for the flake, merging:

@oleg-nenashev oleg-nenashev merged commit dc2fba9 into wiremock:master Jul 11, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants