ServerEvent: replace Guava predicate and function with STL (refs #2111)

[tomasbjerre]

These are the last imports of Predicate and Function from Guava. Perhaps they are left for a reason?

References

#2111

Submitter checklist

• The PR request is well described and justified, including the body and the references
• The PR title represents the desired changelog entry
• The repository's code style is followed (see the contributing guide)
• Test coverage that demonstrates that the change works as expected
• For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

[Mahoney]

My understanding is we want to make this breaking change before going out of beta so I'd guess it's oversight, but perhaps @tomakehurst can confirm as NOT_MATCHED and TO_LOGGED_REQUEST are public and fairly widely used.

[oleg-nenashev]

I am in favor of doing this change for 3.0. If we want to reduce Guava footprint, removing it from APIs is definitely a right thing to do

[oleg-nenashev]

The proposal from @tomasbjerre is to drop static fields entirely as a part of the change. I will document the new locations afterwards

  public static final Function<ServeEvent, LoggedRequest> TO_LOGGED_REQUEST =
      ServeEvent::getRequest;

  public static final Predicate<ServeEvent> NOT_MATCHED = ServeEvent::isNoExactMatch;

[oleg-nenashev]

@tomasbjerre WDYT?

[tomasbjerre]

If you want me to just remove the fields I can do that.

[oleg-nenashev]

@tomasbjerre would be great, thanks!

[tomasbjerre]

@tomasbjerre would be great, thanks!

Fixed

[oleg-nenashev]

+1 for the new version, will ship it.
Thanks a lot @tomasbjerre !