Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IntelliJ Run Configurations #2274

Merged
merged 3 commits into from
Jul 24, 2023

Conversation

picimako
Copy link
Contributor

@picimako picimako commented Jul 17, 2023

Added IntelliJ run configurations for each Gradle commands mentioned in CONTRIBUTING.md.

References

#2273

Submitter checklist

  • The PR request is well described and justified, including the body and the references
  • The PR title represents the desired changelog entry
  • The repository's code style is followed (see the contributing guide)
  • Test coverage that demonstrates that the change works as expected
  • For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

@picimako picimako requested a review from a team as a code owner July 17, 2023 13:10
@picimako
Copy link
Contributor Author

picimako commented Jul 17, 2023

@tomakehurst Thank you. I'll make the changes soon.
Do you want me to update the commands in CONTRIBUTING.md as well?

@tomakehurst
Copy link
Member

@tomakehurst Thank you. I'll make the changes soon. Do you want me to update the commands in CONTRIBUTING.md as well?

Yes please, I think it would make sense for these to be consistent.

@oleg-nenashev oleg-nenashev added the chore Maintenance label Jul 22, 2023
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge after the flaky CI passes.
It would be nice to extend https://github.com/wiremock/wiremock/blob/master/CONTRIBUTING.md and mention this tooling there (and WireMocha too if reasonable for test development?)

@oleg-nenashev oleg-nenashev merged commit 5f0677f into wiremock:master Jul 24, 2023
7 checks passed
@picimako
Copy link
Contributor Author

@oleg-nenashev I'll create a separate PR in the upcoming days to mention the run configurations in CONTRIBUTING.md.
Also, I'll look into the tests in WireMock to see if WireMocha could be utiltized there in any way.

@picimako picimako deleted the intellij-run-configurations branch November 7, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants