Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monorepo support #32

Open
jpwallace22 opened this issue Dec 9, 2023 · 4 comments
Open

Monorepo support #32

jpwallace22 opened this issue Dec 9, 2023 · 4 comments

Comments

@jpwallace22
Copy link

Maybe I am doing something wrong, but I cannot for the life of me deploy from a yarn workspaces monorepo.

I added the base:

// astro.config.msj
{
 base: '/docs',
}

Screenshot 2023-12-09 at 9 35 13 AM

It won't build properly because it won't build my other dependencies.

So if I remove the base, it fails because it can't find the docs/dist directory.

I need a way to build from the root and deploy from a path, but it doesn't seem as though one is exposed.

@nemanjam
Copy link

nemanjam commented Jan 2, 2024

I have same problem with turborepo. Why this action doesn't have additional arguments for this?

@natemoo-re
Copy link
Member

Earlier versions of this action included many options to configure all of the inputs and outputs, but we ended up with many confusing, conflicting configuration options.

If anyone has ideas about options we could add to better support monorepos, please let us know!


Custom build pipelines with more complex requirements can always accomplish the same thing as this action by adding an additional step after the build runs:

    - name: Upload Pages Artifact
      uses: actions/upload-pages-artifact@v3
      with:
        path: "./packages/www/dist/"

@natemoo-re natemoo-re changed the title Cannot deploy from monorepo Monorepo support Jan 3, 2024
@nemanjam
Copy link

nemanjam commented Jan 3, 2024

I built it manually and uploaded it in the end.

https://github.com/nemanjam/nemanjam.github.io/blob/main/.github/workflows/deploy-gh-pages.yml

@natemoo-re
Copy link
Member

Awesome! That is probably the best course of action for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants