Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support node-version-file options of actions/setup-node@v4 #47

Open
NozomuIkuta opened this issue Mar 15, 2024 · 0 comments · May be fixed by #48
Open

Support node-version-file options of actions/setup-node@v4 #47

NozomuIkuta opened this issue Mar 15, 2024 · 0 comments · May be fixed by #48

Comments

@NozomuIkuta
Copy link

Currently, available options of withastro/action@v2 is a subset of those of actions/setup-node@v4.
For example, node-version-file is not available.

In my usecase, I define Node.js as engines.node in package.json.
If I use actions/setup-node@v4 directly, I can specify node-version-file so that it reads the property.
Without this option, I have to manually sync Node.js versions in 2 files, workflow YAML file and package.json.

By the way, pnpm/action-setup@v3 automatically detects package manager and its version based on packageManager property in package.json, if package-manager of withastro/action@v2 is not specified, which enables me to manage package manager version in one place.

It may be fine to support other options of actions/setup-node@v4 too.

@NozomuIkuta NozomuIkuta linked a pull request Mar 15, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant