From 5b84d80eed4686f798a5148195759b030b1a138b Mon Sep 17 00:00:00 2001 From: Emanuele Stoppa Date: Tue, 23 May 2023 13:19:20 +0100 Subject: [PATCH] code review --- packages/astro/src/core/build/plugins/plugin-pages.ts | 9 ++++----- .../astro/src/core/build/plugins/plugin-renderers.ts | 4 +--- 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/packages/astro/src/core/build/plugins/plugin-pages.ts b/packages/astro/src/core/build/plugins/plugin-pages.ts index b5afee60e42bc..63d6711d03675 100644 --- a/packages/astro/src/core/build/plugins/plugin-pages.ts +++ b/packages/astro/src/core/build/plugins/plugin-pages.ts @@ -26,9 +26,9 @@ function vitePluginPages(opts: StaticBuildOptions, internals: BuildInternals): V async load(id) { if (id === resolvedPagesVirtualModuleId) { let importMap = ''; - const imports = []; - const exports = []; - const content = []; + const imports: string[] = []; + const exports: string[] = []; + const content: string[] = []; let i = 0; imports.push(`import { renderers } from "${RENDERERS_MODULE_ID}"`); exports.push(`export { renderers }`); @@ -48,8 +48,7 @@ function vitePluginPages(opts: StaticBuildOptions, internals: BuildInternals): V content.push(`export const pageMap = new Map([${importMap}]);`); - const result = [imports.join('\n'), content.join('\n'), exports.join('\n')]; - return result.join('\n'); + return `${imports.join('\n')}${content.join('\n')}${exports.join('\n')}`; } }, }; diff --git a/packages/astro/src/core/build/plugins/plugin-renderers.ts b/packages/astro/src/core/build/plugins/plugin-renderers.ts index 033b1d9f9d22d..d18eb5a0270fd 100644 --- a/packages/astro/src/core/build/plugins/plugin-renderers.ts +++ b/packages/astro/src/core/build/plugins/plugin-renderers.ts @@ -42,9 +42,7 @@ export function vitePluginRenderers( exports.push(`export const renderers = [${rendererItems}];`); - const result = [imports.join('\n'), exports.join('\n')]; - - return result.join('\n'); + return `${imports.join('\n')}\n${exports.join('\n')}`; } } },