Prevent double uri decoding (#9532)

Author: bluwy

.changeset/old-goats-occur.md

@@ -0,0 +1,5 @@
+---
+'astro': patch
+---
+
+Prevents unnecessary URI decoding when rendering a route

packages/astro/src/core/routing/params.ts

@@ -12,9 +12,9 @@ export function getParams(array: string[]) {
 		const params: Params = {};
 		array.forEach((key, i) => {
 			if (key.startsWith('...')) {
-				params[key.slice(3)] = match[i + 1] ? decodeURIComponent(match[i + 1]) : undefined;
+				params[key.slice(3)] = match[i + 1] ? match[i + 1] : undefined;
 			} else {
-				params[key] = decodeURIComponent(match[i + 1]);
+				params[key] = match[i + 1];
 			}
 		});
 		return params;

packages/astro/src/vite-plugin-astro-server/request.ts

@@ -37,7 +37,7 @@ export async function handleRequest({
 	if (config.trailingSlash === 'never' && !incomingRequest.url) {
 		pathname = '';
 	} else {
-		pathname = decodeURI(url.pathname);
+		pathname = url.pathname;
 	}
 
 	// Add config.base back to url before passing it to SSR

packages/astro/test/ssr-params.test.js

@@ -38,4 +38,14 @@ describe('Astro.params in SSR', () => {
 			expect($('.category').text()).to.equal('food');
 		});
 	});
+
+	it('No double URL decoding', async () => {
+		const app = await fixture.loadTestAdapterApp();
+		const request = new Request('http://example.com/users/houston/%25');
+		const response = await app.render(request);
+		expect(response.status).to.equal(200);
+		const html = await response.text();
+		const $ = cheerio.load(html);
+		expect($('.category').text()).to.equal('%');
+	});
 });