Skip to content

Commit 8aa17a6

Browse files
authoredDec 11, 2023
Add missing global attributes to JSX definition (#9404)
* fix: add some missing attributes to our JSX definitions * chore: changeset * fix: use empty string as type
1 parent f47b85c commit 8aa17a6

File tree

2 files changed

+13
-2
lines changed

2 files changed

+13
-2
lines changed
 

‎.changeset/dull-masks-eat.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'astro': patch
3+
---
4+
5+
Fixed some newer HTML attributes not being included in our type definitions

‎packages/astro/astro-jsx.d.ts

+8-2
Original file line numberDiff line numberDiff line change
@@ -517,7 +517,8 @@ declare namespace astroHTML.JSX {
517517
| 'search'
518518
| 'send'
519519
| undefined
520-
| null;
520+
| null;
521+
exportparts?: string | undefined | null;
521522
hidden?: boolean | string | undefined | null;
522523
id?: string | undefined | null;
523524
inert?: boolean | string | undefined | null;
@@ -533,18 +534,23 @@ declare namespace astroHTML.JSX {
533534
| undefined
534535
| null;
535536
is?: string | undefined | null;
537+
538+
// Microdata API
536539
itemid?: string | undefined | null;
537540
itemprop?: string | undefined | null;
538541
itemref?: string | undefined | null;
539542
itemscope?: boolean | string | undefined | null;
540543
itemtype?: string | undefined | null;
544+
541545
lang?: string | undefined | null;
546+
part?: string | undefined | null;
547+
popover?: boolean | string | undefined | null;
542548
slot?: string | undefined | null;
543549
spellcheck?: 'true' | 'false' | boolean | undefined | null;
544550
style?: string | StyleObject | undefined | null;
545551
tabindex?: number | string | undefined | null;
546552
title?: string | undefined | null;
547-
translate?: 'yes' | 'no' | undefined | null;
553+
translate?: 'yes' | 'no' | '' | undefined | null;
548554

549555
// <command>, <menuitem>
550556
radiogroup?: string | undefined | null;

0 commit comments

Comments
 (0)
Please sign in to comment.