Skip to content

Commit bebf38c

Browse files
authoredDec 12, 2023
fix: mention which feature is experimental/deprecated (#9414)
1 parent 8aeb0b5 commit bebf38c

File tree

2 files changed

+12
-7
lines changed

2 files changed

+12
-7
lines changed
 

‎.changeset/fifty-pets-hunt.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'astro': patch
3+
---
4+
5+
Adds the feature name to logs about feature deprecation / experimental status.

‎packages/astro/src/integrations/astroFeaturesValidation.ts

+7-7
Original file line numberDiff line numberDiff line change
@@ -80,9 +80,9 @@ function validateSupportKind(
8080
if (supportKind === STABLE) {
8181
return true;
8282
} else if (supportKind === DEPRECATED) {
83-
featureIsDeprecated(adapterName, logger);
83+
featureIsDeprecated(adapterName, logger, featureName);
8484
} else if (supportKind === EXPERIMENTAL) {
85-
featureIsExperimental(adapterName, logger);
85+
featureIsExperimental(adapterName, logger, featureName);
8686
}
8787

8888
if (hasCorrectConfig() && supportKind === UNSUPPORTED) {
@@ -94,20 +94,20 @@ function validateSupportKind(
9494
}
9595

9696
function featureIsUnsupported(adapterName: string, logger: Logger, featureName: string) {
97-
logger.error('config', `The feature ${featureName} is not supported (used by ${adapterName}).`);
97+
logger.error('config', `The feature "${featureName}" is not supported (used by ${adapterName}).`);
9898
}
9999

100-
function featureIsExperimental(adapterName: string, logger: Logger) {
100+
function featureIsExperimental(adapterName: string, logger: Logger, featureName: string) {
101101
logger.warn(
102102
'config',
103-
`The feature is experimental and subject to change (used by ${adapterName}).`
103+
`The feature "${featureName}" is experimental and subject to change (used by ${adapterName}).`
104104
);
105105
}
106106

107-
function featureIsDeprecated(adapterName: string, logger: Logger) {
107+
function featureIsDeprecated(adapterName: string , logger: Logger, featureName: string,) {
108108
logger.warn(
109109
'config',
110-
`The feature is deprecated and will be removed in the future (used by ${adapterName}).`
110+
`The feature "${featureName}" is deprecated and will be removed in the future (used by ${adapterName}).`
111111
);
112112
}
113113

0 commit comments

Comments
 (0)
Please sign in to comment.