view transition's form handling honors default prevention (#9486)

martrapp · florian-lefebvre · web-flow · commit f6714f677cff · 2023-12-20T14:44:48.000+01:00
* add missing check to honor prevented default

* added changeset

* Update .changeset/fresh-games-confess.md

Co-authored-by: Florian Lefebvre &lt;contact@florian-lefebvre.dev&gt;

---------

Co-authored-by: Florian Lefebvre &lt;contact@florian-lefebvre.dev&gt;
diff --git a/.changeset/fresh-games-confess.md b/.changeset/fresh-games-confess.md
@@ -0,0 +1,5 @@
+---
+'astro': patch
+---
+
+Fixes View Transition's form submission prevention, allowing `preventDefault` to be used.
diff --git a/packages/astro/components/ViewTransitions.astro b/packages/astro/components/ViewTransitions.astro
@@ -94,7 +94,7 @@ const { fallback = 'animate' } = Astro.props;
 
 		document.addEventListener('submit', (ev) => {
 			let el = ev.target as HTMLElement;
-			if (el.tagName !== 'FORM' || isReloadEl(el)) {
+			if (el.tagName !== 'FORM' || ev.defaultPrevented || isReloadEl(el)) {
 				return;
 			}
 			const form = el as HTMLFormElement;

Original file line number	Diff line number	Diff line change
`@@ -94,7 +94,7 @@ const { fallback = 'animate' } = Astro.props;`
`94`	`94`
`95`	`95`	`document.addEventListener('submit', (ev) => {`
`96`	`96`	`let el = ev.target as HTMLElement;`
`97`		`- if (el.tagName !== 'FORM' \|\| isReloadEl(el)) {`
	`97`	`+ if (el.tagName !== 'FORM' \|\| ev.defaultPrevented \|\| isReloadEl(el)) {`
`98`	`98`	`return;`
`99`	`99`	`}`
`100`	`100`	`const form = el as HTMLFormElement;`