🐛 BUG: inconsistent 127.0.0.1 and localhost in dev and preview

[millette]

What version of astro are you using?

0.23.2

What package manager are you using?

pnpm

What operating system are you using?

Linux

Describe the Bug

Running astro dev, hostname is 127.0.0.1 (and --hostname doesn't do anything) whereas astro preview the hostname is localhost (and here --hostname works as expected - but not yet document withastro/docs#165).

There's a suble difference between localhost and 127.0.0.1 depending on OS configuration (IPv4 vs IPv6, etc.)

Note that the example doesn't really help since it's a cli problem.

Link to Minimal Reproducible Example

https://stackblitz.com/github/gqaiqojag?file=package.json

[wlto]

Getting a similar issue with astro dev as well. I've set localhost as the host in my config file but the CLI log still outputs [astro] Local: http://127.0.0.1:3000/.

Dig a little deeper and I believe the problem is around this line in core dev file (I'm just taking a look at the built file in dist in the boilerplate (via the npm init astro command):

The log on line 23 outputs address { address: '127.0.0.1', family: 'IPv4', port: 3000 }. So it seems like it doesn't respect the host in the Vite config for some reason.

I'm relatively new to open-source development so not sure where to go from here. But just posting my findings here in case it helps. Any insights or advice from the core team would be appreciated. I really like this project so hope I can contribute somehow 😄

[wlto]

Was looking at the difference between the preview and dev code. And noticing that the address in core/preview/index.js is taking the hostname directly from the config file:

Does it make sense if we do something similar for core/dev/index.js?

[wlto]

Some more updates. Figured it might be a Vite bug so took a look at their repo and found this PR: vitejs/vite#7092

So I'm guessing this is something related to Vite.

[wlto]

Good news! The PR I linked above vitejs/vite#7092 was just merged to Vite's main branch. Hopefully we can see a new version with the fix soon :)

[FredKSchott]

Woo! Closing this as an upstream issue. Also, @bholmesdev has been doing some work for v0.24.0 to have an updated CLI output with a new --host flag to match Vite's support more closely. Please try it out with npm install astro@next and report back if you have any issues!