Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HMR doesn't handle scss file changes with @use #7035

Closed
1 task
RolginRoman opened this issue May 8, 2023 · 2 comments · Fixed by #8609
Closed
1 task

HMR doesn't handle scss file changes with @use #7035

RolginRoman opened this issue May 8, 2023 · 2 comments · Fixed by #8609
Assignees
Labels
- P3: minor bug An edge case that only affects very specific usage (priority) feat: hmr Related to HMR (scope)

Comments

@RolginRoman
Copy link

What version of astro are you using?

v2.4.2

Are you using an SSR adapter? If so, which one?

no

What package manager are you using?

yarn

What operating system are you using?

Mac

What browser are you using?

Chrome

Describe the Bug

https://github.com/RolginRoman/astro-scss-changes-miss-hmr-repro

I'm using Sass with Astro. In serve mode scss changes don't reflect on pages with @use sass syntax.
Repro contains one index page and one style file in styles folder.
Seems like it works with @import syntax (I've found this issue #3382 and @import got covered)

However, I'm not sure is it a bug or just misconfiguration cause no additional config was introduced from my side (https://docs.astro.build/en/guides/styling/)

Link to Minimal Reproducible Example

https://github.com/RolginRoman/astro-scss-changes-miss-hmr-repro

Participation

  • I am willing to submit a pull request for this issue.
@bluwy
Copy link
Member

bluwy commented May 25, 2023

I investigated this a bit. It's related to a small upstream issue (vitejs/vite#13344), but even with that HMR for it still doesn't work, so leaving it open.

@bluwy bluwy added the - P3: minor bug An edge case that only affects very specific usage (priority) label May 25, 2023
@natemoo-re
Copy link
Member

Confirming that this is still an issue, even with the upstream issue merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- P3: minor bug An edge case that only affects very specific usage (priority) feat: hmr Related to HMR (scope)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants