refactor: move renderers to their own plugin #7166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: cfa992b The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
ematipico
commented
May 23, 2023
ematipico
force-pushed
the
feat/plugin-renderes
branch
2 times, most recently
from
266c33a
to
c5b63f5
Compare
bluwy
reviewed
May 23, 2023
ematipico
force-pushed
the
feat/plugin-renderes
branch
from
c5b63f5
to
5b84d80
Compare
matthewp
approved these changes
May 23, 2023
ematipico
force-pushed
the
feat/plugin-renderes
branch
from
5b84d80
to
cfa992b
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR moves the code generated for the renderers in its own plugin.
The reason why this is required is that this is code that will be shared among pages, so it makes more sense to have an entry point just for that.
This will be helpful shortly when we'll split pages into multiple entry points, and they will need to import the same code
Testing
The current tests should pass
Docs
N/A