Prevent Vite watching on Astro config load #7171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f2b0a44 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
bluwy
commented
May 23, 2023
| server: { middlewareMode: true, hmr: false }, | ||
| server: { middlewareMode: true, hmr: false, watch: { ignored: ['**/*'] } }, |
There was a problem hiding this comment.
As explained in the PR description, this isn't needed, but I updated anyways so it's consistent with the createViteLoader code.
ematipico
approved these changes
May 23, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
From @ematipico's suggestion #7073 (comment), we could prevent Vite watching when spinning up the Vite dev server.
It looks like the watching is already disabled for content collections /
astro syncvia:astro/packages/astro/src/core/create-vite.ts
Line 155 in 6112671
But I updated the Astro config load flow too as that will benefit from it.
Testing
Logged
viteServer.watcher.getWatched()to verify that directories aren't watched.Docs
n/a. internal improvement.