Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types for import.meta.env.ASSETS_PREFIX and import.meta.env.SITE #7172

Merged
merged 5 commits into from May 23, 2023

Conversation

Princesseuh
Copy link
Member

@Princesseuh Princesseuh commented May 23, 2023

Changes

Added types and documentation for the two base env vars that Astro provide. This PR also includes some minimal type fixes that slipped in in previous update, nothing too major

Fix #7164

Testing

Tested manually

Docs

cc @withastro/maintainers-docs for feedback on the JSDocs

@changeset-bot
Copy link

changeset-bot bot commented May 23, 2023

🦋 Changeset detected

Latest commit: 27ee560

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label May 23, 2023
@Princesseuh Princesseuh merged commit 2ca9426 into main May 23, 2023
14 checks passed
@Princesseuh Princesseuh deleted the fix/import-meta-types branch May 23, 2023 12:13
@astrobot-houston astrobot-houston mentioned this pull request May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide type for the default ASSETS_PREFIX env var
3 participants