New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing flags for the astro check
command
#8237
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hello! Thank you for opening your first PR to Astro’s Docs! 🎉 Here’s what will happen next:
|
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR 🙌 Got 1 suggestion to checkout
Use suggested description for `--preserveWatchOutput` flag Co-authored-by: Atharva <atharvapise19@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for participating in this issue, and then coming in to improve the docs @lifeisfakenews ! This is a super helpful way to contribute, and we're so glad you did!
I've edited some wording a bit, to keep it consistent with our structure on the rest of the page. Also, there's one particular flag that needs a bit of clarification to make the definition the most helpful, I think. Can you take a particular look at that one, and seeing the format of the others, help us get that one in a similar state?
And @at-the-vr thank you for doing a first review tech check on this! It's so helpful! Take a look at the comments I gave on my editing pass (checking for consistent wording on other parts of the page etc.) and feel free to edit more anytime you want to up your review game and check for things like that! 🙌 |
Reworded slightly to follow your suggestions and improved the description for that flag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is looking great! @at-the-vr , would you do one final review on this, and when you're happy, I'm happy!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets Git it Merge 💪
Co-authored-by: Atharva <atharvapise19@gmail.com> Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Atharva <atharvapise19@gmail.com> Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Atharva <atharvapise19@gmail.com> Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>
Description (required)
Added the flags that are missing from the current documentation for the
astro check
cli commandCurrently, only the
--watch
flag is documented, however there are several other options available for the command (--minimumSeverity
or--preserveWatchOutput
for example)Related issues & labels (optional)