Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃挕 RFC: Allow breakpoints in .astro files #468

Closed
1 of 3 tasks
Vap0r1ze opened this issue Jan 5, 2023 · 1 comment 路 Fixed by #470
Closed
1 of 3 tasks

馃挕 RFC: Allow breakpoints in .astro files #468

Vap0r1ze opened this issue Jan 5, 2023 · 1 comment 路 Fixed by #470

Comments

@Vap0r1ze
Copy link

Vap0r1ze commented Jan 5, 2023

Background & Motivation

Using vitejs/vite#11576 and withastro/compiler#680, I'm able to use debugger; statements in frontmatter flawlessly.
Code_4quUaJQw11

The only missing piece of this puzzle now is the ability to create breakpoints in .astro files. I'm opening this issue here because I assume it's up to the LSP / extension to declare that the file can have breakpoints, and what lines/columns to allow them.

Proposed Solution

Allowing breakpoints in .astro files

Help make it happen!

  • I am willing to submit a PR to implement this change.
  • I am willing to submit a PR to implement this change, but would need some guidance.
  • I am not willing to submit a PR to implement this change.
@Princesseuh
Copy link
Member

Fair request! I think this is actually easy to add, just need to add the breakpoints field to the extension's package.json.

If you're interested in doing the PR, go ahead! Otherwise I'll take a look at it tomorrow 9AM (currently 22 in my timezone at the time of writing)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants