Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 BUG: class and object constructors lose their color on VS Code Astro extension #788

Closed
Firgrep opened this issue Feb 12, 2024 · 1 comment · Fixed by #793
Closed
Labels
- P3: minor bug An edge case that only affects very specific usage (priority) ecosystem: upstream Issue is caused by a bug / missing feature upstream pkg: ts-plugin Fixes to the TS plugin are required to fix this issue (scope)

Comments

@Firgrep
Copy link

Firgrep commented Feb 12, 2024

Describe the Bug

The astro extension on VS code appears to switch off the green coloring for class objects. Object and NextResponse should be green, but instead they're light-blue like normal variables. (I'm using color theme dark modern, but it appears to also affect other themes).

Screenshot 2024-02-12 133304
Screenshot 2024-02-12 133311

Steps to Reproduce

  1. Have Astro extension installed on VS Code.
  2. Open up or make a typescript file and make a class constructed object, e.g. Object.keys(someObject) and see that Object is not appearing as normally green in VS Code's color config.
  3. Go to extensions and disable Astro.
  4. Watch the color of Object revert to green as expected.
@github-actions github-actions bot added the needs triage Issue needs to be triaged label Feb 12, 2024
@Princesseuh
Copy link
Member

Princesseuh commented Feb 12, 2024

Great catch! It seems like this works inside Astro files directly, so it must be something related to our TypeScript plugin. Nowadays our TypeScript plugin essentially does nothing by itself, and everything happens in Volar itself. As such, this is most likely an issue upstream that might be affecting other frameworks using Volar.

@Princesseuh Princesseuh added pkg: ts-plugin Fixes to the TS plugin are required to fix this issue (scope) - P3: minor bug An edge case that only affects very specific usage (priority) ecosystem: upstream Issue is caused by a bug / missing feature upstream and removed needs triage Issue needs to be triaged labels Feb 12, 2024
johnsoncodehk added a commit to volarjs/volar.js that referenced this issue Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- P3: minor bug An edge case that only affects very specific usage (priority) ecosystem: upstream Issue is caused by a bug / missing feature upstream pkg: ts-plugin Fixes to the TS plugin are required to fix this issue (scope)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants