Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 BUG: Go to problems after version 2.9.0 #876

Open
zanhk opened this issue May 17, 2024 · 5 comments
Open

馃悰 BUG: Go to problems after version 2.9.0 #876

zanhk opened this issue May 17, 2024 · 5 comments
Labels
needs triage Issue needs to be triaged

Comments

@zanhk
Copy link

zanhk commented May 17, 2024

Describe the Bug

System: windows
vscode: 1.89.1 (latest)

Some version of the extension have problems with the go to

Extension version recap:
2.8.6: Go to works correctly
2.9.0 to 2.9.1: Go to does nothing
2.10.0 to 2.10.2: Go to open a non-existing file .0.mts

my vscode settings

{
	"css.customData": [".vscode/tailwind.json"],
	"workbench.editor.labelFormat": "short",
	"workbench.tree.indent": 16,
	"workbench.editor.highlightModifiedTabs": true,
	"workbench.editor.limit.enabled": true,
	"workbench.editor.limit.perEditorGroup": true,
	"workbench.editor.limit.value": 7,
	"files.defaultLanguage": "${activeEditorLanguage}",
	"files.trimTrailingWhitespace": true,
	"files.autoGuessEncoding": true,
	"files.insertFinalNewline": true,
	"editor.suggestSelection": "first",
	"editor.tabCompletion": "on",
	"editor.detectIndentation": false,
	"editor.insertSpaces": false,
	"editor.acceptSuggestionOnEnter": "off",
	"editor.defaultFormatter": "biomejs.biome",
	"editor.linkedEditing": true,
	"editor.inlineSuggest.enabled": true,
	"editor.wordSeparators": "`~!@%^&*()-=+[{]}\\|;:'\",.<>/?",
	"editor.bracketPairColorization.enabled": true,
	"editor.bracketPairColorization.independentColorPoolPerBracketType": true,
	"editor.acceptSuggestionOnCommitCharacter": false,
	"editor.guides.bracketPairs": true,
	"editor.inlayHints.enabled": "offUnlessPressed",
	"editor.minimap.enabled": false,
	"editor.cursorBlinking": "solid",
	"editor.gotoLocation.multipleDefinitions": "goto",
	"editor.gotoLocation.multipleTypeDefinitions": "goto",
	"editor.gotoLocation.multipleDeclarations": "goto",
	"editor.gotoLocation.multipleImplementations": "goto",
	"editor.gotoLocation.multipleReferences": "goto",
	"terminal.integrated.copyOnSelection": true,
	"terminal.integrated.defaultProfile.windows": "Command Prompt",
	"terminal.integrated.enableMultiLinePasteWarning": "never",
	"explorer.incrementalNaming": "smart",
	"explorer.compactFolders": false,
	"debug.openDebug": "openOnDebugBreak",
	"debug.allowBreakpointsEverywhere": true,
	"javascript.updateImportsOnFileMove.enabled": "always",
	"typescript.updateImportsOnFileMove.enabled": "always",
	"typescript.inlayHints.parameterNames.enabled": "all",
	"extensions.ignoreRecommendations": true,
	"emmet.triggerExpansionOnTab": true,
	"references.preferredLocation": "view",
	"vsintellicode.modify.editor.suggestSelection": "automaticallyOverrodeDefaultValue",
	"json.schemaDownload.enable": true,
	"livePreview.notifyOnOpenLooseFile": false,
	"livePreview.customExternalBrowser": "Chrome",
	"livePreview.debugOnExternalPreview": true,
	"tailwindCSS.emmetCompletions": true,
	"tailwindCSS.validate": true,
	"tailwindCSS.classAttributes": ["class", "className", "ngClass", "class:list"],
	"cSpell.language": "en,it",
	"cSpell.diagnosticLevel": "Information",
	"[astro]": {
		"editor.defaultFormatter": "astro-build.astro-vscode"
	}
}

Steps to Reproduce

  • open an astro project with the latest version of the extension with windows
  • do go to in a variable

tested in a empty project adding

<script>
	var a = 1;
</script>
@github-actions github-actions bot added the needs triage Issue needs to be triaged label May 17, 2024
@johnsoncodehk
Copy link
Contributor

tested in a empty project adding

<script>
	var a = 1;
</script>

Hi @zanhk, could you provide the complete code for this section?

@zanhk
Copy link
Author

zanhk commented May 23, 2024

@johnsoncodehk I ll upload the entire repo, but it's just the default astro minimal template with that script, the script it's irrelevant, the problem happen doing goto in any script variable

@zanhk
Copy link
Author

zanhk commented May 26, 2024

@johnsoncodehk Here a video where I reproduce the problem

google_screen_recording_2024-05-26T13-29_58.951Z.webm

and a repo if you need, but as said it happen with every script

https://github.com/zanhk/astro-goto-problems

@johnsoncodehk
Copy link
Contributor

This issue may have been fixed at volarjs/services@873bba3.

This is the install package for #879, could you check if the problem still exists?

astro-vscode-2.10.2-volar-2.3.vsix.zip

@zanhk
Copy link
Author

zanhk commented Jun 1, 2024

Hi @johnsoncodehk, yes with that package the problem still persist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Issue needs to be triaged
Projects
None yet
Development

No branches or pull requests

2 participants