Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usage of deprecated ActivityTestRule #3134

Open
d4vidi opened this issue Dec 12, 2021 · 2 comments
Open

Remove usage of deprecated ActivityTestRule #3134

d4vidi opened this issue Dec 12, 2021 · 2 comments
Assignees
@gosha212
Labels
📌 pinned platform: android status: triage type: enhancement ⚡️

Comments

@d4vidi
Copy link
Collaborator

d4vidi commented Dec 12, 2021 •
edited

Is your feature request related to a problem? Please describe.
Introducing #2817 would officially make the users' code in DetoxTest.java use a deprecated AndroidX-Test API (i.e. the ActivityTestRule class), which is undesired and in a sense can be considered a tech debt.

Associated with this discussion: #2838

Describe the solution you'd like
Don't use ActivityTestRule. Instead, introduce a Detox encapsulation which implements an Espresso rule under the covers. Most likely, should be done using ActivityScenarioRule.

Describe alternatives you’ve considered
N/A

Additional context
N/A
@stale
Copy link

stale bot commented Jan 12, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you believe the issue is still relevant, please test on the latest Detox and report back.

Thank you for your contributions!

For more information on bots in this reporsitory, read this discussion.

@stale stale bot added the 🏚 stale label Jan 12, 2022
@stale
Copy link

stale bot commented Jan 19, 2022

The issue has been closed for inactivity.

@stale stale bot closed this as completed Jan 19, 2022
@d4vidi d4vidi reopened this Jan 19, 2022
@d4vidi d4vidi added this to the Detox20 milestone Apr 13, 2022
@d4vidi d4vidi removed this from the Detox20 milestone May 17, 2022
@gosha212 gosha212 assigned gosha212 and unassigned d4vidi Apr 16, 2024
@gosha212 gosha212 mentioned this issue May 8, 2024
Closed
2 tasks
@gosha212 gosha212 linked a pull request May 8, 2024 that will close this issue
Feat/3134 remove usage of deprecated activitytestrule #4486
Closed
2 tasks
@gosha212 gosha212 mentioned this issue May 12, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gosha212 gosha212

Labels
📌 pinned platform: android status: triage type: enhancement ⚡️
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat/3134 remove usage of deprecated activitytestrule wix/Detox
2 participants
@d4vidi @gosha212