Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove style attributes in favor of CSS class #41

Open
blakestone95 opened this issue Jan 17, 2019 · 1 comment
Open

Remove style attributes in favor of CSS class #41

blakestone95 opened this issue Jan 17, 2019 · 1 comment
Labels

Comments

@blakestone95
Copy link

A team member switched us to this library from material-design-icons, but it messed up a bunch of our styling. After perusing the source code, I have a suggestion: remove the style attributes used in Icon and SvgIcon and instead use a CSS class (perhaps className="react-icons-kit") with some CSS to apply the inline-block and vertical-align rules. My reasoning is that this will make it easier to style the icons and override your defaults without having to add a className and style to every Icon component.

@wmira
Copy link
Owner

wmira commented Mar 30, 2019

@blakestone95 apologies for the very late reply. I will update this such that users should be able to compose a specific container of their liking -- e.g. with their own default className. styles will also be not added by default. Will update once it gets released

@wmira wmira added the task label Jun 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants