Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update noxfile.py to have better support for Windows #298

Closed
Peilonrayz opened this issue Mar 15, 2020 · 0 comments · Fixed by #519
Closed

Update noxfile.py to have better support for Windows #298

Peilonrayz opened this issue Mar 15, 2020 · 0 comments · Fixed by #519

Comments

@Peilonrayz
Copy link
Contributor

When developing I run nox -r before finishing a commit so I know that I can push without problems. Whilst I find and fix most errors, docs and cover never complete successfully. This is causing fractured PRs, as I don't know coverage has fallen - as it always errors - until it's too late.

Coverage

Coverage fails to run on the following lines.

  • nox/virtualenv.py

  • nox/workflow.py

    • 57 (44->57)

Docs

  1. Change rm -rf to shutil.rmtree.

  2. Change the Python version to 3.7 because sphinx-autobuild, which relies on tornado, no longer works on Windows on 3.8.

  3. Sphinx fails to follow the reference to changelog and contributing.
    Since the files don't have a heading this causes some warnings. Since the -W flag is passed this elevates them to errors.

    I have found two solutions:

    • Converting everything to rst, and use include.
    • Don't use the -W flag on Windows.

Most of the fixes are rather straight forward. However Docs (3) seems controversial, how would you like me to approach it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants