Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant license inclusion on MANIFEST.in #504

Closed
DiddiLeija opened this issue Nov 18, 2021 · 3 comments · Fixed by #505
Closed

Redundant license inclusion on MANIFEST.in #504

DiddiLeija opened this issue Nov 18, 2021 · 3 comments · Fixed by #505

Comments

@DiddiLeija
Copy link
Collaborator

I was reading the MANIFEST.in file, and found this line:

https://github.com/theacodes/nox/blob/7443a93582a47a7dc680d90d6afeb686368e3985/MANIFEST.in#L1

However, https://packaging.python.org/guides/using-manifest-in/#how-files-are-included-in-an-sdist says that the license file defined by license_file (at setup.cfg) is included by default by newer versions of Setuptools. The license_file is:

https://github.com/theacodes/nox/blob/7443a93582a47a7dc680d90d6afeb686368e3985/setup.cfg#L11

I just want to know if the MANIFEST.in inclusion is redundant in our case, since I don't know how does build includes files. Also, if that's the case, I offer to open a PR to fix that.

@cjolowicz
Copy link
Collaborator

cjolowicz commented Nov 18, 2021

Thanks for catching that! We require setuptools >= 42 in our pyproject.toml, so removing the line from MANIFEST.in should be safe.

@DiddiLeija
Copy link
Collaborator Author

Excellent! I'll post a PR in a few muntes.

@DiddiLeija
Copy link
Collaborator Author

I created #505 to fix this.

@DiddiLeija DiddiLeija changed the title Question: Possible "redundant license inclusion" on MANIFEST.in Redundant license inclusion on MANIFEST.in Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants