Missing copyright notices?

[DiddiLeija]

Describe the bug

I don't know a lot about the Apache License. But as far as I know, the code should contain a copyright notice, according to these
lines: https://github.com/theacodes/nox/blob/main/LICENSE#L189-L201

However, I just noticed that these files does not contain that notice:

• https://github.com/theacodes/nox/blob/e7ae509ac1b46820953cb8a5793c95d47070928c/nox/_decorators.py
• https://github.com/theacodes/nox/blob/e7ae509ac1b46820953cb8a5793c95d47070928c/nox/_typing.py

How to reproduce

Just browse the files above. They don't contain a copyright notice like the others (see https://github.com/theacodes/nox/blob/e7ae509ac1b46820953cb8a5793c95d47070928c/nox/sessions.py for an example).

Expected behavior

I don't know if this is a bug at all. I expected the copyright notices in those files. But maybe it's my mistake, I'm not sure.

[DiddiLeija]

Since this is a license/copyright issue, I want to know @theacodes opinion.

[theacodes]

Sure, they should be added.

…

On Wed, Nov 24, 2021 at 1:47 PM Diego Ramirez ***@***.***> wrote: Since this is a license/copyright issue, I want to know @theacodes <https://github.com/theacodes> opinion. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#507 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAB5I45BULH2CSTZ4LYODRLUNUXNJANCNFSM5IWJIQYA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[DiddiLeija]

Ok. Can I work on it? Or would you like to do it? Also, I noticed that the existing notices have different dates: 2016, 2017, 2019... Is that ok?

[theacodes]

Yes, the date is the date of original publication.

…

On Fri, Nov 26, 2021, 12:03 PM Diego Ramirez ***@***.***> wrote: Ok. Can I work on it? Or would you like to do it? Also, I noticed that the existing notices have different dates: 2016, 2017, 2019... Is that ok? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#507 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAB5I462QXDM75NQSXLY2SLUN64X3ANCNFSM5IWJIQYA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[DiddiLeija]

Ok. If you agree, the next week I'll investigate the publication date of the missing files, and post a PR to add the copyright notices. Of course, if you don't disagree 😄.

[theacodes]

Totally fine with me 🙂

…

On Fri, Nov 26, 2021, 1:23 PM Diego Ramirez ***@***.***> wrote: Ok. If you agree, the next week I'll investigate the publication date of the missing files, and post a PR to add the copyright notices. Of course, if you don't disagree 😄. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#507 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAB5I4ZVU5HA366TACWKDL3UN7GB3ANCNFSM5IWJIQYA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[DiddiLeija]

@theacodes, I created #509 to fix this. Please review it and tell me if I should add the copyright in another place 😃.