Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update modules to use logger #144

Open
3 of 23 tasks
LinuxMercedes opened this issue Jun 27, 2017 · 3 comments
Open
3 of 23 tasks

Update modules to use logger #144

LinuxMercedes opened this issue Jun 27, 2017 · 3 comments
Labels

Comments

@LinuxMercedes
Copy link
Member

LinuxMercedes commented Jun 27, 2017

#143 introduces a proper logger, rather than just using console.log everywhere. Modules need to be updated to use it.

This is a list of modules containing the string "console.log" that probably need to be converted to use a logger instead:

  • blerg
  • dota2
  • dumbCommandModule
  • github
  • google
  • join
  • newegg
  • nickserv
  • nicovideo
  • ping
  • qdb
  • que
  • quo
  • schedule
  • scrollback
  • title
  • tumblr-insult
  • twitter
  • vimeo
  • weather
  • wolf
  • wotd
  • youtube
@euank
Copy link
Member

euank commented Jun 28, 2017

I believe the examples in the testlog module are decently exhaustive.

The preferred method would be via ether the first (for anything with no changes in 'this', i.e. no arr.forEach or such), or the last (using 'init' to initialize a var log module variable).

@LinuxMercedes
Copy link
Member Author

Scrollback switched in #150

@iliana
Copy link
Collaborator

iliana commented Mar 6, 2018

dumbCommandModule switched in #190

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants