Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onUrl: Provide already-parsed URL objects to modules #157

Open
iliana opened this issue Sep 19, 2017 · 2 comments
Open

onUrl: Provide already-parsed URL objects to modules #157

iliana opened this issue Sep 19, 2017 · 2 comments

Comments

@iliana
Copy link
Collaborator

iliana commented Sep 19, 2017

From #156:

Something I've been thinking about idly — I wonder if it'd be nice to provide the already-parsed URL object without breaking the API somehow. (The mastodon module I'm writing is just going to url.parse what it gets again.)

@LinuxMercedes
Copy link
Member

We could pass it as a new last argument to url/dupeurl without breaking anything, I think?

@euank
Copy link
Member

euank commented Sep 19, 2017

There are few enough consumers of url I'm fine not being backwards compatible. In practice, I'm not sure that the majority actually pass it straight to url.parse again though, especially since things like request libraries take strings as urls, not url objects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants