Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Module: More info on push notification #35

Open
euank opened this issue Jul 8, 2014 · 2 comments
Open

Github Module: More info on push notification #35

euank opened this issue Jul 8, 2014 · 2 comments

Comments

@euank
Copy link
Member

euank commented Jul 8, 2014

Specifically, I think a git.io link + the commit message would be great. Example: from the official github irc service thing:

<git-notification> [ponscripter-fork] euank pushed 1 new commit to master: http://git.io/N-WAkA
<git-notification> ponscripter-fork/master f1c2ad5 Euank: Backport SDL2 fix from upstream...

You could likely compact it into one line or tweak it in other ways, but I think it's important to get most of the information there. Specifically, commit link, commit message, repository info, and committer.

@cbgbt
Copy link
Collaborator

cbgbt commented Jul 8, 2014

Do you happen to know what the official service does if you've pushed multiple commits? Does it output a line for each one?

I didn't include a link to the commit because there can be several commits for a push.

@cbgbt
Copy link
Collaborator

cbgbt commented Jul 8, 2014

Looks like github combines all of the commits into a comparison page:
8f6743d...69ab144

It then prints the sha and commit message for each commit on a separate line. I'm not sure there is a way to print that in an appealing manner without multiline.

cbgbt pushed a commit that referenced this issue Jul 8, 2014
The bot now prints the commit message header from ever commit in a push.
The link generated in push messages now points to a web page showing  complete
  diff of the entire push.

Not done --
Generating git.io links. This would require reworking the irc message portion to
be asynchronous.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants