Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AnnotationLayer.css and TextLayer.css to be in sync with pdf-js 3.6.172 #1503

Merged
merged 4 commits into from
May 24, 2023
Merged

Update AnnotationLayer.css and TextLayer.css to be in sync with pdf-js 3.6.172 #1503

merged 4 commits into from
May 24, 2023

Conversation

unrevised6419
Copy link
Contributor

@unrevised6419 unrevised6419 commented May 24, 2023

Update AnnotationLayer.css and TextLayer.css to be in sync with pdf-js@3.6.172

ps: For future contributors that reference this PR for updating styles, please check also the resolved comments

Sorry, something went wrong.

@unrevised6419 unrevised6419 changed the title Synchronise Text and Annotation layer styles with v3.6.172 Sync Text and Annotation layer styles with v3.6.172 May 24, 2023
@unrevised6419 unrevised6419 changed the title Sync Text and Annotation layer styles with v3.6.172 Sync Text and Annotation layers CSS with v3.6.172 May 24, 2023
Copy link
Owner

@wojtekmaj wojtekmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the changes are okay, but see my comments above - unfortunately we can't just copy pdfjs-dist CSS character by character.

@unrevised6419
Copy link
Contributor Author

Ok @wojtekmaj I'm applying the changes right now.

@unrevised6419
Copy link
Contributor Author

Changes done. Did a rebase on top of origin/main

@unrevised6419
Copy link
Contributor Author

unrevised6419 commented May 24, 2023

Did a build in the root folder, and I'm running yarn dev in the test folder,
But I'm not getting the last changes from the repo 🤔

Verified

This commit was signed with the committer’s verified signature.
bhrutledge Brian Rutledge

Verified

This commit was signed with the committer’s verified signature.
bhrutledge Brian Rutledge

Verified

This commit was signed with the committer’s verified signature.
bhrutledge Brian Rutledge

Verified

This commit was signed with the committer’s verified signature.
bhrutledge Brian Rutledge
@wojtekmaj wojtekmaj changed the title Sync Text and Annotation layers CSS with v3.6.172 Update TextLayer.css and AnnotationLayer.css to be in sync with pdf-js 3.6.172 May 24, 2023
@wojtekmaj
Copy link
Owner

Looks like everything's working.

Nice! Thanks!

@wojtekmaj wojtekmaj merged commit 304fcb9 into wojtekmaj:main May 24, 2023
@wojtekmaj wojtekmaj changed the title Update TextLayer.css and AnnotationLayer.css to be in sync with pdf-js 3.6.172 Update AnnotationLayer.css and TextLayer.css to be in sync with pdf-js 3.6.172 May 24, 2023
@unrevised6419
Copy link
Contributor Author

unrevised6419 commented May 24, 2023

@wojtekmaj I updated the steps I did in the PR description to match all the reviews you did. For the future you can refer anyone to this PR to see some "instructions" on how to update styles 🙂

@unrevised6419 unrevised6419 deleted the sync-styles branch May 24, 2023 20:47
@wojtekmaj
Copy link
Owner

Oh that's amazing! Always great to have some proper docs :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants