Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron 4.0.1 Meteor bundle cut-off at random (seemingly) #220

Closed
KoenLav opened this issue Jan 5, 2019 · 5 comments
Closed

Electron 4.0.1 Meteor bundle cut-off at random (seemingly) #220

KoenLav opened this issue Jan 5, 2019 · 5 comments

Comments

@KoenLav
Copy link
Contributor

KoenLav commented Jan 5, 2019

When running meteor-desktop 2.0 with Meteor 1.8 and Electron 4.0.1 it seems the bundle gets cut off at at random point, rendering execution errors when using npm run desktop.

I realize this version is not yet supported, but just wanted to see whether others are experiencing the same issue or it is specific to our setup.

Electron 3.0.14 works just fine, with the same setup.

@KoenLav
Copy link
Contributor Author

KoenLav commented Jan 6, 2019

Likely to be related to: electron/electron#16213

Or rarher; caused by.

@vladimiry
Copy link

If you don't serve really huge files, I guess registerBufferProtocol can be a reliable replacement for registerStreamProtocol, so you serve the data as a whole piece, electron/electron#13519 (comment).

@KoenLav
Copy link
Contributor Author

KoenLav commented Jan 6, 2019

@vladimiry thanks!

@wojtkowiak any specific reason you decided to use registerStreamProtocol over, for instance, registerBufferProtocol (or one of the other available register......Protcol functions)?

@sferoze
Copy link

sferoze commented Jan 8, 2019

Just wanted to say that I also did try Electron 4.0 and could not get it to work. When building it would error out, and I thought it had to do with babel not compiling something correctly.

But Electron 3.0 works fine

@KoenLav
Copy link
Contributor Author

KoenLav commented Jan 29, 2019

This has been resolved with Electron 4.0.3 (registerStreamProtocol fix).

@KoenLav KoenLav closed this as completed Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants