Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert edit.js to edit.tsx and replace propTypes with TypeScript definitions #42363

Open
nielslange opened this issue May 19, 2023 · 2 comments · May be fixed by woocommerce/woocommerce-blocks#9782
Open

Convert edit.js to edit.tsx and replace propTypes with TypeScript definitions #42363

nielslange opened this issue May 19, 2023 · 2 comments · May be fixed by woocommerce/woocommerce-blocks#9782
Assignees
@Sidsector9
Labels
priority: normal The issue/PR is of normal priority—not many people are affected or there’s a workaround, etc. team: Kirigami & Origami type: cooldown Things that are queued for a cooldown period (assists with planning). type: enhancement The issue is a request for an enhancement. type: refactor The issue/PR is related to refactoring.

Comments

@nielslange
Copy link
Member

Problem

assets/js/blocks/products/all-products/edit.js is a JS file and uses propTypes definitions.

Expected outcome

  1. Convert the file from edit.js to edit.tsx.
  2. Replace propTypes with TypeScript definitions.
@nielslange nielslange added type: enhancement The issue is a request for an enhancement. type: refactor The issue/PR is related to refactoring. type: cooldown Things that are queued for a cooldown period (assists with planning). labels May 19, 2023
@Sidsector9 Sidsector9 linked a pull request Jun 11, 2023 that will close this issue
Open
7 tasks
@Sidsector9
Copy link
Member

@nielslange I have worked on this issue as my first attempt at converting JS to TS. Please let me know how I can request for review.

@nielslange
Copy link
Member Author

@nielslange I have worked on this issue as my first attempt at converting JS to TS. Please let me know how I can request for review.

Thanks for your contribution, @Sidsector9! 🙌 I requested a review from the corresponding team in your PR.

@ObliviousHarmony ObliviousHarmony transferred this issue from woocommerce/woocommerce-blocks Dec 11, 2023
@nielslange nielslange added the priority: normal The issue/PR is of normal priority—not many people are affected or there’s a workaround, etc. label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sidsector9 Sidsector9

Labels
priority: normal The issue/PR is of normal priority—not many people are affected or there’s a workaround, etc. team: Kirigami & Origami type: cooldown Things that are queued for a cooldown period (assists with planning). type: enhancement The issue is a request for an enhancement. type: refactor The issue/PR is related to refactoring.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Convert all products edit to TypeScript Sidsector9/woocommerce-blocks
3 participants
@nerrad @nielslange @Sidsector9