Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

woocommerce_new_order triggers on checkout visiting #45145

Open
5 tasks done
islamBelabbes opened this issue Feb 26, 2024 · 3 comments · May be fixed by #47422
Open
5 tasks done

woocommerce_new_order triggers on checkout visiting #45145

islamBelabbes opened this issue Feb 26, 2024 · 3 comments · May be fixed by #47422
Assignees
@wavvves
Labels
focus: checkout Issues related to checkout page. priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. team: Rubik Store API checkout endpoints, Mini-Cart, Cart and Checkout related issues type: community contribution

Comments

@islamBelabbes
Copy link

islamBelabbes commented Feb 26, 2024 •
edited

Prerequisites

  • I have carried out troubleshooting steps and I believe I have found a bug.
  • I have searched for similar bugs in both open and closed issues and cannot find a duplicate.

Describe the bug

hey ,

It looks like WooCommerce's latest version has a bug.

using 

The woocommerce_new_order hook gets triggered on checkout page visits and is not as expected. 
I have reproduced a bug for three clean WordPress installations.
Please note that it gets triggered only on the first checkout page visit on the specific cart key. 

Expected behavior

woocommerce_new_order triggers on new order

Actual behavior

woocommerce_new_order triggers on checkout page visited

Steps to reproduce

1 - Enable WP debug

2- paste this code into functions.php

add_action("woocommerce_new_order","any",20,1);
function any($order_id){
    error_log("new triggred --------|");
}

3- if your cart has items make sure to place a new order
4 - and then go back and add item(s) to your cart and visit the checkout page
then check your debug file

WordPress Environment

`

WordPress Environment

WordPress address (URL): http://dev2.local
Site address (URL): http://dev2.local
WC Version: 8.6.1
REST API Version: ✔ 8.6.1
WC Blocks Version: ✔ 11.8.0-dev
Action Scheduler Version: ✔ 3.7.1
Log Directory Writable: ✔
WP Version: 6.4.3
WP Multisite: –
WP Memory Limit: 256 MB
WP Debug Mode: ✔
WP Cron: ✔
Language: en_US
External object cache: –

Server Environment

Server Info: nginx/1.16.0
PHP Version: 8.1.23
PHP Post Max Size: 1,000 MB
PHP Time Limit: 1200
PHP Max Input Vars: 4000
cURL Version: 7.77.0
OpenSSL/1.1.1t

SUHOSIN Installed: –
MySQL Version: 8.0.16
Max Upload Size: 300 MB
Default Timezone is UTC: ✔
fsockopen/cURL: ✔
SoapClient: ✔
DOMDocument: ✔
GZip: ✔
Multibyte String: ✔
Remote Post: ✔
Remote Get: ✔

Database

WC Database Version: 8.6.1
WC Database Prefix: wp_
Total Database Size: 5.30MB
Database Data Size: 3.60MB
Database Index Size: 1.70MB
wp_woocommerce_sessions: Data: 0.02MB + Index: 0.02MB + Engine InnoDB
wp_woocommerce_api_keys: Data: 0.02MB + Index: 0.03MB + Engine InnoDB
wp_woocommerce_attribute_taxonomies: Data: 0.02MB + Index: 0.02MB + Engine InnoDB
wp_woocommerce_downloadable_product_permissions: Data: 0.02MB + Index: 0.06MB + Engine InnoDB
wp_woocommerce_order_items: Data: 0.02MB + Index: 0.02MB + Engine InnoDB
wp_woocommerce_order_itemmeta: Data: 0.02MB + Index: 0.03MB + Engine InnoDB
wp_woocommerce_tax_rates: Data: 0.02MB + Index: 0.06MB + Engine InnoDB
wp_woocommerce_tax_rate_locations: Data: 0.02MB + Index: 0.03MB + Engine InnoDB
wp_woocommerce_shipping_zones: Data: 0.02MB + Index: 0.00MB + Engine InnoDB
wp_woocommerce_shipping_zone_locations: Data: 0.02MB + Index: 0.03MB + Engine InnoDB
wp_woocommerce_shipping_zone_methods: Data: 0.02MB + Index: 0.00MB + Engine InnoDB
wp_woocommerce_payment_tokens: Data: 0.02MB + Index: 0.02MB + Engine InnoDB
wp_woocommerce_payment_tokenmeta: Data: 0.02MB + Index: 0.03MB + Engine InnoDB
wp_woocommerce_log: Data: 0.02MB + Index: 0.02MB + Engine InnoDB
wp_actionscheduler_actions: Data: 0.02MB + Index: 0.11MB + Engine InnoDB
wp_actionscheduler_claims: Data: 0.02MB + Index: 0.02MB + Engine InnoDB
wp_actionscheduler_groups: Data: 0.02MB + Index: 0.02MB + Engine InnoDB
wp_actionscheduler_logs: Data: 0.02MB + Index: 0.03MB + Engine InnoDB
wp_commentmeta: Data: 0.02MB + Index: 0.03MB + Engine InnoDB
wp_comments: Data: 0.02MB + Index: 0.09MB + Engine InnoDB
wp_links: Data: 0.02MB + Index: 0.02MB + Engine InnoDB
wp_options: Data: 2.48MB + Index: 0.06MB + Engine InnoDB
wp_postmeta: Data: 0.02MB + Index: 0.03MB + Engine InnoDB
wp_posts: Data: 0.06MB + Index: 0.06MB + Engine InnoDB
wp_term_relationships: Data: 0.02MB + Index: 0.02MB + Engine InnoDB
wp_term_taxonomy: Data: 0.02MB + Index: 0.03MB + Engine InnoDB
wp_termmeta: Data: 0.02MB + Index: 0.03MB + Engine InnoDB
wp_terms: Data: 0.02MB + Index: 0.03MB + Engine InnoDB
wp_usermeta: Data: 0.02MB + Index: 0.03MB + Engine InnoDB
wp_users: Data: 0.02MB + Index: 0.05MB + Engine InnoDB
wp_wc_admin_note_actions: Data: 0.05MB + Index: 0.02MB + Engine InnoDB
wp_wc_admin_notes: Data: 0.06MB + Index: 0.00MB + Engine InnoDB
wp_wc_category_lookup: Data: 0.02MB + Index: 0.00MB + Engine InnoDB
wp_wc_customer_lookup: Data: 0.02MB + Index: 0.03MB + Engine InnoDB
wp_wc_download_log: Data: 0.02MB + Index: 0.03MB + Engine InnoDB
wp_wc_order_addresses: Data: 0.02MB + Index: 0.06MB + Engine InnoDB
wp_wc_order_coupon_lookup: Data: 0.02MB + Index: 0.03MB + Engine InnoDB
wp_wc_order_operational_data: Data: 0.02MB + Index: 0.03MB + Engine InnoDB
wp_wc_order_product_lookup: Data: 0.02MB + Index: 0.06MB + Engine InnoDB
wp_wc_order_stats: Data: 0.02MB + Index: 0.05MB + Engine InnoDB
wp_wc_order_tax_lookup: Data: 0.02MB + Index: 0.03MB + Engine InnoDB
wp_wc_orders: Data: 0.02MB + Index: 0.11MB + Engine InnoDB
wp_wc_orders_meta: Data: 0.05MB + Index: 0.03MB + Engine InnoDB
wp_wc_product_attributes_lookup: Data: 0.02MB + Index: 0.02MB + Engine InnoDB
wp_wc_product_download_directories: Data: 0.02MB + Index: 0.02MB + Engine InnoDB
wp_wc_product_meta_lookup: Data: 0.02MB + Index: 0.09MB + Engine InnoDB
wp_wc_rate_limits: Data: 0.02MB + Index: 0.02MB + Engine InnoDB
wp_wc_reserved_stock: Data: 0.02MB + Index: 0.00MB + Engine InnoDB
wp_wc_tax_rate_classes: Data: 0.02MB + Index: 0.02MB + Engine InnoDB
wp_wc_webhooks: Data: 0.02MB + Index: 0.02MB + Engine InnoDB

Post Type Counts

attachment: 1
page: 7
post: 2
product: 1
shop_order_placehold: 14
wp_template: 2

Security

Secure connection (HTTPS): ❌
Your store is not using HTTPS. Learn more about HTTPS and SSL Certificates.
Hide errors from visitors: ✔

Active Plugins (1)

WooCommerce: by Automattic – 8.6.1

Inactive Plugins (0)

Settings

API Enabled: –
Force SSL: –
Currency: DZD (د.ج)
Currency Position: left_space
Thousand Separator: .
Decimal Separator: ,
Number of Decimals: 2
Taxonomies: Product Types: external (external)
grouped (grouped)
simple (simple)
variable (variable)

Taxonomies: Product Visibility: exclude-from-catalog (exclude-from-catalog)
exclude-from-search (exclude-from-search)
featured (featured)
outofstock (outofstock)
rated-1 (rated-1)
rated-2 (rated-2)
rated-3 (rated-3)
rated-4 (rated-4)
rated-5 (rated-5)

Connected to Woo.com: –
Enforce Approved Product Download Directories: ✔
HPOS feature screen enabled: ✔
HPOS feature enabled: ✔
Order datastore: Automattic\WooCommerce\Internal\DataStores\Orders\OrdersTableDataStore
HPOS data sync enabled: –

WC Pages

Shop base: #6 - /shop/
Cart: #7 - /cart/
Checkout: #8 - /checkout/
My account: #9 - /my-account/
Terms and conditions: ❌ Page not set

Theme

Name: Astra
Version: 4.6.5
Author URL: https://wpastra.com/about/?utm_source=theme_preview&utm_medium=author_link&utm_campaign=astra_theme
Child Theme: ❌ – If you are modifying WooCommerce on a parent theme that you did not build personally we recommend using a child theme. See: How to create a child theme
WooCommerce Support: ✔

Templates

Overrides: –

Admin

Enabled Features: activity-panels
analytics
product-block-editor
coupons
core-profiler
customer-effort-score-tracks
import-products-task
experimental-fashion-sample-products
shipping-smart-defaults
shipping-setting-tour
homescreen
marketing
mobile-app-banner
navigation
onboarding
onboarding-tasks
product-variation-management
product-virtual-downloadable
product-external-affiliate
product-grouped
product-linked
remote-inbox-notifications
remote-free-extensions
payment-gateway-suggestions
shipping-label-banner
subscriptions
store-alerts
transient-notices
woo-mobile-welcome
wc-pay-promotion
wc-pay-welcome-page

Disabled Features: customize-store
minified-js
new-product-management-experience
product-pre-publish-modal
settings
async-product-editor-category-field

Daily Cron: ✔ Next scheduled: 2024-02-27 16:26:57 +00:00
Options: ✔
Notes: 64
Onboarding: skipped

Action Scheduler

Complete: 26
Oldest: 2024-02-26 16:28:00 +0000
Newest: 2024-02-26 16:56:34 +0000

Failed: 1
Oldest: 2024-02-26 16:28:35 +0000
Newest: 2024-02-26 16:28:35 +0000

Pending: 1
Oldest: 2024-02-27 16:28:00 +0000
Newest: 2024-02-27 16:28:00 +0000

Status report information

Generated at: 2024-02-26 17:11:23 +00:00
`

Isolating the problem

  • I have deactivated other plugins and confirmed this bug occurs when only WooCommerce plugin is active.
  • This bug happens with a default WordPress theme active, or Storefront.
  • I can reproduce this bug consistently using the steps above.
@lanej0 lanej0 added focus: checkout Issues related to checkout page. team: Rubik Store API checkout endpoints, Mini-Cart, Cart and Checkout related issues labels Feb 28, 2024
@wavvves
Copy link
Contributor

wavvves commented Mar 14, 2024

Hello @islamBelabbes, Thank you for reporting this. I was able to reproduce it successfully, and I will add it to our backlog.
An important detail, when you say that WC latest has a bug, was this working correctly for a previous WooCommerce version? If so, which one?
This information would greatly speed up the process of determining impact and get a fix shipped with a higher priority.
Thanks

@wavvves wavvves added the priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. label Mar 14, 2024
@islamBelabbes
Copy link
Author

Hey, @wavvves,
Yes, it was working fine in the previous versions. I really can't tell which version, but I can tell that the issue is happening in this function.

public function create( &$order ) {}

located in: s\woocommerce\src\Internal\DataStores\Orders\OrdersTableDataStore.php
errr

@ralucaStan
Copy link
Contributor

Internal discussion p1714402809247599-slack-C8X6Q7XQU

@wavvves wavvves self-assigned this May 10, 2024
@wavvves wavvves changed the title woocommerce_new_order triggres on checkout visiting woocommerce_new_order triggers on checkout visiting May 13, 2024
@wavvves wavvves linked a pull request May 13, 2024 that will close this issue
Fixed "woocommerce_new_order" triggering on order creation/update for both CPT and HPOS orders, regarding draft statuses #47422
Open
11 tasks
@wavvves wavvves linked a pull request May 13, 2024 that will close this issue
Open
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wavvves wavvves

Labels
focus: checkout Issues related to checkout page. priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. team: Rubik Store API checkout endpoints, Mini-Cart, Cart and Checkout related issues type: community contribution
Projects
None yet
Milestone
No milestone
4 participants
@lanej0 @ralucaStan @wavvves @islamBelabbes