Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Experimental] Product Filters Redesign > Clear Button: Fix CSS Not Found error #47481

Merged
merged 4 commits into from
May 16, 2024
Merged

[Experimental] Product Filters Redesign > Clear Button: Fix CSS Not Found error #47481

merged 4 commits into from
May 16, 2024
+13 −0

Conversation

thealexandrelara
Copy link
Contributor

Changes proposed in this Pull Request:

This PR fixes an error in the console due to the lack of the CSS file for the Product Filter Clear Button block.

Closes #47480.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Open the console in your browser;
  2. Visit the post/site editor;
  3. Make sure you don't see any error related to CSS not being found in the page.
    3.1. The error that was appearing was/wp-content/plugins/woocommerce/assets/client/blocks/product-filter-clear-button.css?ver=wc-9.0.0 net::ERR_ABORTED 404 (Not Found).

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

Fix CSS error on the Product Filter Clear Button block

@thealexandrelara thealexandrelara self-assigned this May 14, 2024
@woocommercebot woocommercebot requested review from a team and Aljullu and removed request for a team May 14, 2024 17:35
@thealexandrelara thealexandrelara added type: bug The issue is a confirmed bug. block-type: filter blocks Issues related to all of the filter blocks. labels May 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

Hi @Aljullu,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label May 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 14, 2024 •
edited

Test using WordPress Playground

The changes in this pull request can be previewed and tested using a WordPress Playground instance.
WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Test this pull request with WordPress Playground.

Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit.

Aljullu
Aljullu reviewed May 15, 2024
View reviewed changes
Copy link
Contributor

@Aljullu Aljullu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, @thealexandrelara! Code changes look, I just left one question to understand the purpose of the CSS file.

plugins/woocommerce-blocks/assets/js/blocks/product-filter/inner-blocks/clear-button/style.scss Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this CSS really needed or is it only in order to create a file so the warning goes away? Wondering if instead we should simply mark this block as not having a stylesheet, something like this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great suggestion! I forgot about this method, but included your suggestion in f78ad33. Thank you for sharing this!

Aljullu
Aljullu approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@Aljullu Aljullu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, thanks! 🚢

@thealexandrelara thealexandrelara merged commit 0a5ab94 into trunk May 16, 2024
35 checks passed
@thealexandrelara thealexandrelara deleted the fix/47480-product-filter-button-css-error branch May 16, 2024 18:59
@github-actions github-actions bot added this to the 9.0.0 milestone May 16, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label May 16, 2024
@alvarothomas alvarothomas added status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aljullu Aljullu Aljullu approved these changes

Assignees

@thealexandrelara thealexandrelara

Labels
block-type: filter blocks Issues related to all of the filter blocks. plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris type: bug The issue is a confirmed bug.
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

Product Filters Redesign: Fix Product Filter Clear Button CSS error
3 participants
@thealexandrelara @Aljullu @alvarothomas