Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product Editor: Modal block editor undo is too granular #47508

Closed
5 tasks done
Tracked by #45676
mattsherman opened this issue May 15, 2024 · 0 comments · Fixed by #47524
Closed
5 tasks done
Tracked by #45676

Product Editor: Modal block editor undo is too granular #47508

mattsherman opened this issue May 15, 2024 · 0 comments · Fixed by #47524
Assignees
Labels
focus: new product ux revamped product management experience team: Mothra type: bug The issue is a confirmed bug.

Comments

@mattsherman
Copy link
Contributor

Prerequisites

  • I have carried out troubleshooting steps and I believe I have found a bug.
  • I have searched for similar bugs in both open and closed issues and cannot find a duplicate.

Describe the bug

The undo mechanism in the new product editor's modal block editor (description field) is too granular. Every keypress results in a new entry in the undo history. This is different behavior than the post editor, and quickly fills the undo history, which makes it less useful for users.

Depending on timing, there can also be instances where two identical history entries are made, which results in an undo not doing anything (undoing again will then actually undo something).

Expected behavior

The undo mechanism should work more similar in granularity to the post editor.

Screen.Recording.2024-05-15.at.08.50.22.mov

Actual behavior

The undo mechanism is too granular, recording every keypress.

Screen.Recording.2024-05-15.at.08.53.24.mov

Steps to reproduce

With a WooCommerce env with the new product editor enabled (WooCommerce > Settings > Advanced > Features > Experimental features)...

  1. Go to Products > Add New
  2. Click on Description > Full Editor to bring up the modal editor
  3. Type some text
  4. Undo/redo and verify that every keystroke is undone

WordPress Environment

n/a

Isolating the problem

  • I have deactivated other plugins and confirmed this bug occurs when only WooCommerce plugin is active.
  • This bug happens with a default WordPress theme active, or Storefront.
  • I can reproduce this bug consistently using the steps above.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: new product ux revamped product management experience team: Mothra type: bug The issue is a confirmed bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant