Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Performance]: Replace classnames usage with clsx #47602

Closed
nerrad opened this issue May 19, 2024 · 0 comments · Fixed by #47760
Closed

[Performance]: Replace classnames usage with clsx #47602

nerrad opened this issue May 19, 2024 · 0 comments · Fixed by #47760
Assignees
@nefeline
Labels
focus: performance The issue/PR is related to performance. team: Kirigami & Origami team: Mothra team: Rubik Store API checkout endpoints, Mini-Cart, Cart and Checkout related issues type: cooldown Things that are queued for a cooldown period (assists with planning). type: enhancement The issue is a request for an enhancement. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team.

Comments

@nerrad
Copy link
Contributor

nerrad commented May 19, 2024

Describe the solution you'd like

I noticed that Gutenberg has switched to using clsx which is a faster and lighter alternative to classnames. In Gutenberg's case, this resulted in about a kilobyte of savings.

Let's see what size savings we can get across WooCommerce code by using this alternative.

I've assigned this to all the teams that work the most in JavaScript since any of you could pick it up.

Describe alternatives you've considered

No response

Additional context

No response
@nerrad nerrad added type: enhancement The issue is a request for an enhancement. focus: performance The issue/PR is related to performance. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. team: Mothra team: Rubik Store API checkout endpoints, Mini-Cart, Cart and Checkout related issues team: Kirigami & Origami type: cooldown Things that are queued for a cooldown period (assists with planning). labels May 19, 2024
@nefeline nefeline self-assigned this May 23, 2024
@nefeline nefeline linked a pull request May 23, 2024 that will close this issue
[Performance]: Replace classnames usage with clsx #47760
Merged
11 tasks
@nefeline nefeline mentioned this issue May 23, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nefeline nefeline

Labels
focus: performance The issue/PR is related to performance. team: Kirigami & Origami team: Mothra team: Rubik Store API checkout endpoints, Mini-Cart, Cart and Checkout related issues type: cooldown Things that are queued for a cooldown period (assists with planning). type: enhancement The issue is a request for an enhancement. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Performance]: Replace classnames usage with clsx woocommerce/woocommerce
2 participants
@nerrad @nefeline